rcmgr: use netip.Prefix as map key instead of string#3264
Merged
Conversation
We're converting this prefix to string for storing in maps. There's no need to as prefix is a value type that can be used as a key. No functional change expected.
MarcoPolo
approved these changes
Apr 4, 2025
Collaborator
MarcoPolo
left a comment
MarcoPolo
left a comment
There was a problem hiding this comment.
Nice. This was likely a holdover from when I was using the net package instead of netip. Thank you
guillaumemichel
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're converting this prefix to string for storing in maps. There's no need to, as netip.prefix is a value type that can be used as a key.
No functional change expected.