Conversation
sukunrt
force-pushed
the
push-oyvxvxylmoqo
branch
2 times, most recently
from
85922e3 to
8ade0e2
Compare
Contributor
|
This also removes the go-leveldb-datastore dependency. There's no reason to test with levelDB. This code should work with any compliant go-datastore. It would have been nice if the default MapDB in go-datastore were threadsafe Fixes: #3250
sukunrt
force-pushed
the
push-oyvxvxylmoqo
branch
from
8ade0e2 to
a416bd5
Compare
guillaumemichel
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the go-leveldb-datastore dependency. There's no
reason to test with levelDB. This code should work with any compliant
go-datastore.
Bumps go-datastore to latest as it removes the go-process dependency.
Fixes: #3250