Skip to content

autonatv2: explicitly handle dns addrs #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukunrt merged 1 commit into from
Mar 24, 2025
Merged

autonatv2: explicitly handle dns addrs #3249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion p2p/protocol/autonatv2/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,9 @@ func amplificationAttackPrevention(observedAddr, dialAddr ma.Multiaddr) bool {
if err != nil {
return true
}
dialIP, _ := manet.ToIP(dialAddr) // must be an IP multiaddr
dialIP, err := manet.ToIP(dialAddr) // can be dns addr
if err != nil {
return true
}
return !observedIP.Equal(dialIP)
}
7 changes: 7 additions & 0 deletions p2p/protocol/autonatv2/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,13 @@ func TestDefaultAmplificationAttackPrevention(t *testing.T) {

t2 := ma.StringCast("/ip4/1.1.1.1/tcp/1235") // different IP
require.True(t, amplificationAttackPrevention(q2, t2))

// always ask dial data for dns addrs
d1 := ma.StringCast("/dns/localhost/udp/1/quic-v1")
d2 := ma.StringCast("/dnsaddr/libp2p.io/tcp/1")
require.True(t, amplificationAttackPrevention(d1, t1))
require.True(t, amplificationAttackPrevention(d2, t1))

}

func FuzzServerDialRequest(f *testing.F) {
Expand Down
Loading