Merged
Conversation
MarcoPolo
approved these changes
Mar 22, 2025
Member
Author
|
Can we include #3225 in the release? |
Collaborator
|
We can unexport it for the patch, and then re-export it for the next release |
This context wasn't being cancelled on all code paths. In particular, contexts for connections that didn't complete negotiation were not being cancelled. The change arranges for either `udpmux.muxedConnection.Close` or `RemoveConnByUfrag` to call the other. Fixes: #3223
reuse port didn't work for the second transport, either QUIC or WebTransport, that was used for listening. This change fixes it by calling associate on all paths. This impacted hole punching for some users since you cannot hole punch without reuse port. There's a test in holepunch package to prevent regressions. Fixes #3165 Co-authored-by: Marco Munizaga <git@marcopolo.io>
Cutting a Release (when not on
|
Member
Author
|
Unexported that variable in this commit: 1b3b1ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.