Skip to content

Comments

build(test_analysis): use modernc.org/sqlite directly#3227

Merged
MarcoPolo merged 1 commit intolibp2p:masterfrom
levisyin:build/test-analysis
Apr 11, 2025
Merged

build(test_analysis): use modernc.org/sqlite directly#3227
MarcoPolo merged 1 commit intolibp2p:masterfrom
levisyin:build/test-analysis

Conversation

@levisyin
Copy link
Contributor

@levisyin levisyin commented Mar 8, 2025

Motivation

image

Based on the comment from glebarez:

I think we can use modernc.org/sqlite directly instead of glebarez/go-sqlite(we didn't use GORM).

Result

Following are a part of results of test_results.db after replacing by modernc.org/sqlite:

sqlite> select * from test_results limit 10;
           Time = 2025-03-08T11:24:42.688922377+08:00
         Action = start
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = 
        Elapsed = 0.0
         Output = 
BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.688985794+08:00
         Action = run
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = 
BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.688989916+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = === RUN   TestFailsOnConsistentFailure

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.688999891+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = === RUN   TestConsistentFailure

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.689003091+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output =     main_test.go:7: consistent failure

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.689005556+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = --- FAIL: TestConsistentFailure (0.00s)

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.689007838+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = FAIL

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.689010234+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = FAIL  example.com/test        0.002s

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.689014079+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = 2025/03/08 11:21:39 Not all tests passed: exit status 1

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

           Time = 2025-03-08T11:24:42.689182934+08:00
         Action = output
        Package = github.com/libp2p/go-libp2p/scripts/test_analysis
           Test = TestFailsOnConsistentFailure
        Elapsed = 0.0
         Output = 2025/03/08 11:21:39 Found 1 failed tests. Retrying them 4 times

BatchInsertTime = 2025-03-08T11:24:42.602364369+08:00

@levisyin levisyin force-pushed the build/test-analysis branch from d9353f0 to 87b579f Compare March 10, 2025 23:46
@MarcoPolo MarcoPolo force-pushed the build/test-analysis branch from 87b579f to 0c760dd Compare March 19, 2025 18:33
@levisyin levisyin force-pushed the build/test-analysis branch 2 times, most recently from 2e2ad47 to 1b4fa57 Compare March 27, 2025 15:31
@levisyin levisyin force-pushed the build/test-analysis branch from 1b4fa57 to 7e7d4e7 Compare April 6, 2025 15:07
@levisyin levisyin force-pushed the build/test-analysis branch from 7e7d4e7 to 05c53c3 Compare April 10, 2025 14:50
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@MarcoPolo MarcoPolo merged commit 58d21ca into libp2p:master Apr 11, 2025
8 checks passed
@levisyin levisyin deleted the build/test-analysis branch April 11, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants