build(test_analysis): use modernc.org/sqlite directly#3227
Merged
MarcoPolo merged 1 commit intolibp2p:masterfrom Apr 11, 2025
Merged
build(test_analysis): use modernc.org/sqlite directly#3227MarcoPolo merged 1 commit intolibp2p:masterfrom
modernc.org/sqlite directly#3227MarcoPolo merged 1 commit intolibp2p:masterfrom
Conversation
d9353f0 to
87b579f
Compare
87b579f to
0c760dd
Compare
2e2ad47 to
1b4fa57
Compare
1b4fa57 to
7e7d4e7
Compare
7e7d4e7 to
05c53c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Based on the comment from glebarez:
I think we can use
modernc.org/sqlitedirectly instead ofglebarez/go-sqlite(we didn't use GORM).Result
Following are a part of results of
test_results.dbafter replacing bymodernc.org/sqlite: