Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/quic-go/quic-go dependency #2780

Merged
merged 6 commits into from
May 8, 2024

Conversation

fasmat
Copy link
Contributor

@fasmat fasmat commented May 3, 2024

This updates the quic-go dependency to the newest version. The webtransport.Dialer interface changed in a non-backwards compatible way so I had to make some minor changes to the code to be able to use the updated dependency.

Fixes #2783

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'll let the libp2p team take it from here

@fasmat
Copy link
Contributor Author

fasmat commented May 7, 2024

After seeing most tests fail I updated the dependencies of the modules in the examples and test-plan folders. I missed them in my initial submission.

@sukunrt
Copy link
Member

sukunrt commented May 8, 2024

examples are related to the latest libp2p version. We shouldn't update them here. We will update the examples go.mod after we make the next release(v0.34)

Why are the example tests failing?

@fasmat
Copy link
Contributor Author

fasmat commented May 8, 2024 via email

@MarcoPolo
Copy link
Collaborator

We don't use do replace github.com/libp2p/go-libp2p => ../ in the examples on purpose. It leads to noisier changes and the examples make sense to reference a released version of go-libp2p.

Tidy in test-plans because we want to test the head for interop
@MarcoPolo MarcoPolo merged commit a86d94e into libp2p:master May 8, 2024
1 of 2 checks passed
@fasmat fasmat deleted the update-webtransport branch May 8, 2024 20:37
@fasmat
Copy link
Contributor Author

fasmat commented May 8, 2024

Why are the example tests failing?

The tests were not failing just test-plans because it used a replacement while the examples didn't. I should have only called go mod tidy on test-plans instead of updating all go.mod files in the examples package...

@fasmat fasmat mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest (v0.33.2) go-libp2p not compatible with latest (v0.8.0) quic-go/webtransport-go
4 participants