-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github.com/quic-go/quic-go dependency #2780
Conversation
242e627
to
8bbcc4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'll let the libp2p team take it from here
After seeing most tests fail I updated the dependencies of the modules in the |
examples are related to the latest libp2p version. We shouldn't update them here. We will update the examples go.mod after we make the next release(v0.34) Why are the example tests failing? |
The examples module does import the latest version of go-libp2p by replacement. Some examples in the examples dir however don't. Go mod tidy fails on the modules that use replacement not on those that don't.
EDIT: my comment was not correct - sorry. Examples do not use replacement. Thanks @MarcoPolo for updating the PR 🙂
|
This reverts commit e03cb1d.
We don't use do |
Tidy in test-plans because we want to test the head for interop
The tests were not failing just |
This updates the
quic-go
dependency to the newest version. Thewebtransport.Dialer
interface changed in a non-backwards compatible way so I had to make some minor changes to the code to be able to use the updated dependency.Fixes #2783