autonat: Clean up after close #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/close-autonat-service
branch
from
baf63ae
to
0fe6fe3
Compare
sukunrt
approved these changes
Mar 25, 2024
Comment on lines
+276
to
+280
| func (as *autoNATService) Close() error { | ||
| as.Disable() | ||
| return as.config.dialer.Close() | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we just close the dialer from the autonat instance? That seems better, we ensure that the dialer is always closed even if for some reason there's an issue with service being set to nil for some reason.
I don't have strong opinions here.
There was a problem hiding this comment.
My read here is that the dialer is owned by the service, so it's the service's responsibility to close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autonat would leave a couple of dangling go routines because it wouldn't close the swarm or the peerstore. Fixes #2743.