Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: testify fixes #2666

Merged
merged 4 commits into from
Feb 14, 2024
Merged

chore: testify fixes #2666

merged 4 commits into from
Feb 14, 2024

Conversation

dozyio
Copy link
Contributor

@dozyio dozyio commented Dec 9, 2023

  • Updated a bunch of require.Equals to use the correct expected, actual format
  • Replaced a few tests with require equivalents

sukunrt
sukunrt requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Replaced a few tests with require equivalents

Can we remove this set of changes from this PR?

Using t.Fatalf etc is fine.

@dozyio
Copy link
Contributor Author

dozyio commented Dec 17, 2023

Can we remove this set of changes from this PR?

Using t.Fatalf etc is fine.

done, thanks - let me know if you want anything else reverting

@p-shahi p-shahi requested a review from sukunrt February 8, 2024 06:46
@sukunrt sukunrt merged commit e3b0a86 into libp2p:master Feb 14, 2024
10 of 11 checks passed
@sukunrt
Copy link
Member

sukunrt commented Feb 14, 2024

Thanks @dozyio

@dozyio dozyio deleted the chore-testify-lint branch March 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dozyio @sukunrt