Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pstoremanager: fix race condition when removing peers from peer store #2644

Merged
merged 1 commit into from
Nov 17, 2023
Merged

pstoremanager: fix race condition when removing peers from peer store #2644

merged 1 commit into from
Nov 17, 2023

Conversation

marten-seemann
Copy link
Contributor

For #2643.

@juligasa could you try out this PR?

@juligasa
Copy link

Unfortunately, after doing go get github.com/libp2p/go-libp2p@5a419b2a0327bb9e9f97c25410ed42f7a312fb0e in local app and re-running, I still see peers (who run the previous libp2p version) reporting zero protocols -according to peerstore-

@marten-seemann marten-seemann merged commit 2844691 into master Nov 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marten-seemann @juligasa @sukunrt