New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: remove unused 'SetStreamHandler' #2598

Merged

sukunrt merged 1 commit into libp2p:master from joohhnnn:patch-1

Nov 11, 2023

Contributor

joohhnnn commented Oct 8, 2023

in this echo case, sender is no need to SetStreamHandler, the sender node only used to interact with listener node.


          remove unused 'SetStreamHandler'

4cf085f

sukunrt approved these changes

View reviewed changes

Member

sukunrt commented Oct 10, 2023

Thanks @joohhnnn

marten-seemann added the merge-after-hacktober label

sukunrt merged commit 1d84b7d into libp2p:master

8 of 10 checks passed

kaichaosun mentioned this pull request

Remove unused stream handler for sender in example/echo #2635

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-after-hacktober