use standard library sha256 implementation for Go 1.21 #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
force-pushed
the
update-go-multihash
branch
from
15197f8
to
a18ccec
Compare
There was a problem hiding this comment.
Change looks fine to me. Thank you @Jorropo!
I'll hold off my approval since this is not yet tested on CI (and can't be tested, since quic-go currently makes it possible to even compile go-libp2p with Go 1.21).
marten-seemann
added
the
status/blocked
|
@Jorropo Can you please rebase and update go-multihash to v0.2.3? I'd like to include this in the v0.30 release later today, but I can't push to your branch. |
Jorropo
force-pushed
the
update-go-multihash
branch
from
a18ccec
to
129dca1
Compare
Jorropo
changed the title
See rational and benchmarks in multiformats/go-multihash#173. Fixes: libp2p#2308
Jorropo
force-pushed
the
update-go-multihash
branch
from
129dca1
to
6e6da49
Compare
|
@marten-seemann done |
Jorropo
removed
the
status/blocked
|
Unrelated autorelay failure, rerunning the test suite. |
marten-seemann
changed the title
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rational and benchmarks in multiformats/go-multihash#173.
Fixes: #2308