This repository has been archived by the owner on May 26, 2022. It is now read-only.
Don't drop connections when simultaneous dialing occurs #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt in duplicate connections, but it's better to have two connections than dropping both of them and ending up with zero connections.
Stebalien
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
TL;DR: this happens in the public network very infrequently, but happens in tests frequently. The downsides of merging this are:
- We're more likely to form multiple connections. Of course, we'd previously simultaneously disconnect so we'll just have to say that multiple connections are better than no connections.
- Technically,
DialPeercould continue to block after we have made a successful connection. Unfortunately, short-cutting that is a bit tricky as, if we did that, we'd have to somehow continue the dial off in the background with no owners (which would make it uncancelable).
TL;DR: anything we do here will be suboptimal but this is better than what we currently have.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only cancel dials when an outbound connection succeeds. This may result in duplicate connections, but it's better to have two connections than dropping both of them and ending up with zero connections.
This is not the long-term solution to this issue since we'd rather not be able to accidentally end up with two connections, but for now this should do the job.