This repository has been archived by the owner on May 26, 2022. It is now read-only.
switch from gzip to zstd for qlog compression #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jan 21, 2021
|
Why would it not? klauspost/compress/zstd is a pure Go implementation. |
|
It should be fine. I just want to make sure because other packages in that repo do use CGO, and sometimes the CGO dependency ends up leaking if people aren't careful. |
|
Just confirmed that it actually builds with CGO_ENABLED=0. It does. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a high-bandwidth connection, qlogging consumes about ~40% CPU, of which 1/4 is spent on JSON encoding an 3/4 is spent on running gzip. Switching from gzip to zstd reduces the time spent on compression to 1/2 of the time spent on JSON encoding. That's a speedup of 6x.
Changing the compression level doesn't actually have a large influence on the file size (in my tests I wasn't able to gain more than 10% by increasing it), so using the fastest compression makes sense here. The zst file will be roughly as large as the gzip file.