Gossipsub Extensions #630
Merged
Gossipsub Extensions #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
commented
Jul 9, 2025
MarcoPolo
force-pushed
the
marco/extensions
branch
from
996ce03 to
97ebfb9
Compare
MarcoPolo
force-pushed
the
marco/extensions
branch
from
4f69cbd to
222428a
Compare
ppopth
reviewed
Aug 28, 2025
ppopth
reviewed
Aug 28, 2025
ppopth
reviewed
Aug 28, 2025
ppopth
reviewed
Aug 28, 2025
ppopth
reviewed
Aug 28, 2025
| } | ||
|
|
||
| func (e *testExtension) AddPeer(id peer.ID) { | ||
| e.sendRPC(id, &RPC{ |
There was a problem hiding this comment.
Since you send an RPC here, should you read it from your peer as well?
There was a problem hiding this comment.
Yes. Might be easier to test as well. thanks!
MarcoPolo
force-pushed
the
marco/extensions
branch
from
222428a to
5299023
Compare
|
Just a friendly reminder that you can view the diffs between versions of these commits at: or (preferred) by locally running: The latter is preferred as it also tells you which commit introduced the change. |
MarcoPolo
force-pushed
the
marco/extensions
branch
2 times, most recently
from
18833cc to
7402459
Compare
Useful to let protocols add to the first message
MarcoPolo
force-pushed
the
marco/extensions
branch
2 times, most recently
from
939defb to
4e4faae
Compare
MarcoPolo
force-pushed
the
marco/extensions
branch
from
4e4faae to
857c8cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Merge:
An alternative would be to rely on peers ignoring protobuf messages they don't understand. It seems better to explicitly signal support for the Extensions control Message and only send it if you know your peer supports it. I'll create a new specs issue/PR to discuss this.
This implements the Gossipsub Extensions Control Message from libp2p/specs#684. It also implements the Test Extension libp2p/specs#686 as an interop test.
There is a rust-libp2p implementation, and using the gossip-interop tester, I've tested interop between these implementations for the Test Extension.
Don't let the diff stats scare you, they are mostly generated protobuf code.