Fix: Own our CertifiedAddrBook #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gossipsub.go
Outdated
| @@ -522,6 +529,45 @@ func (gs *GossipSubRouter) Attach(p *PubSub) { | |||
| } | |||
| } | |||
|
|
|||
| func (gs *GossipSubRouter) manageAddrBook() error { | |||
There was a problem hiding this comment.
could we just not return anything?
There was a problem hiding this comment.
it should, the error is ignored anyway.
There was a problem hiding this comment.
Can you return nothing and log errors?
These are just swallowed now.
vyzo
reviewed
Apr 25, 2024
sukunrt
reviewed
Apr 25, 2024
MarcoPolo
force-pushed
the
own-certified-addr-book
branch
from
e3c2e92
to
699a45b
Compare
|
@vyzo this is ready |
vyzo
reviewed
May 20, 2024
| &event.EvtPeerConnectednessChanged{}, | ||
| }) | ||
| if err != nil { | ||
| log.Errorf("failed to subscribe to peer identification events: %v", err) |
There was a problem hiding this comment.
and return, as it may panic trying to access sub.Out in the loop
|
Hmm, need to investigate why the test is failing. |
Merged
It's the resource manager being IP aware :) |
MarcoPolo
force-pushed
the
own-certified-addr-book
branch
from
1a80eaa
to
94969bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked until the next go-libp2p release that includes libp2p/go-libp2p#2759, but please still review.
Fixes GossipSub's Peer Exchange (PX) after go-libp2p's change to stop consuming signed peer records into its Certified Address book.
I'll briefly summarize the problem and this solution here, but for more context please follow the links below.
The problem:
The proposed solution in this PR:
A slightly more long term solution would be for go-libp2p to support services libp2p/go-libp2p#1993 that can provide resources that can be shared amongst other services/protocols. Imagine if two services needed a certified address book, then it would make sense to have a separate service that could provide an up to date address book.
For now potentially duplicating data if multiple services require a certified addr book seems like an okay solution.
Related though, is anyone aware of other protocols that depend on the host's certified address book?
Fixes libp2p/go-libp2p#2754
Related to: libp2p/go-libp2p#2355