Configurable outbound peer queue sizes #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Nov 15, 2019
pubsub.go
Outdated
| // We start dropping messages to a peer if the outbound queue if full | ||
| func WithPeerOutboundQueueSize(size int) Option { | ||
| return func(p *PubSub) error { | ||
| if size < 0 { |
There was a problem hiding this comment.
I see what you mean. Because we write the HelloPacket to the queue before we start the go-routine that reads from it & dispatches it. Thanks for pointing this out.
There was a problem hiding this comment.
@vyzo Have addressed this. Let me know if you have any concerns before we merge this.
pdyraga
added a commit
to keep-network/keep-core
that referenced
this pull request
Jan 20, 2020
This version will let us set peer peer outbound queue size to avoid problems with messages dropped when this queue is full during DKG. libp2p/go-libp2p-pubsub#230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #217 as enlisted in #220
Low hanging fruit :) The other tasks enlisted in #217 will be next.