Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Discovery #184

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Add Discovery #184

merged 3 commits into from
Oct 31, 2019
+1,740 −507

Commits on Oct 31, 2019

  1. dep: update go-libp2p

    @aschmahmann
    aschmahmann committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    c837436 View commit details
    Browse the repository at this point in the history

  2. interface: New Topic + TopicEventHandlers objects. 

    Added PubSub.Join(topic) that returns a Topic object. This object can be Subscribed and Published to as well as to get a TopicEventHandler for topic events. This means that the Subscription object will no longer handle PeerEvents and that PubSub's Publish and Subscribe functions are deprecated.
    @aschmahmann
    aschmahmann committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    5ef7439 View commit details
    Browse the repository at this point in the history

  3. Added libp2p discovery capabilities to PubSub. 

    When the WithDiscovery option is passed to PubSub then PubSub will be able to search for more peers that are interested in our topics.

This includes the ability for Publishes (via Topic.Publish()) to block until the router is ready to publish. When a router is ready is currently defined by a combination of a user defined MinTopicSize function (passed into topic.Publish via the WithReadiness publish option) and the properties of the pubsub router used. The discovery tests show example usage.
    @aschmahmann
    aschmahmann committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    f9c26c2 View commit details
    Browse the repository at this point in the history