don't delete under the read lock #76

vyzo · 2019-04-28T08:36:25Z

Fixes the panic in #75 and also reworks the gc logic to happen in the background with a periodic process.
Closes #75

let gc clean up the addrs

vyzo · 2019-04-28T08:50:36Z

We might also want to schedule a periodic gc.

vyzo · 2019-04-28T13:15:52Z

And possibly stop the eager gc on Update/Add, just rely on the periodic process.

Stebalien

IIRC, I implemented that weird GC logic to avoid a background task because the peerstore didn't have a close method. However, now that it does, this is definitely much cleaner.

don't delete under the read lock

d0a3cc1

let gc clean up the addrs

vyzo requested a review from Stebalien April 28, 2019 08:36

ghost assigned vyzo Apr 28, 2019

ghost added the status/in-progress In progress label Apr 28, 2019

vyzo added 2 commits April 28, 2019 12:17

periodically schedule gc

e4cf501

add Close method to memory address book, which cancels the gc process

c58ce1f

don't eager gc

f21f6ea

Stebalien approved these changes Apr 28, 2019

View reviewed changes

Stebalien merged commit 96639ef into master Apr 28, 2019

ghost removed the status/in-progress In progress label Apr 28, 2019

Stebalien deleted the fix/issue-75 branch April 28, 2019 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't delete under the read lock #76

don't delete under the read lock #76

vyzo commented Apr 28, 2019 •

edited

Loading

vyzo commented Apr 28, 2019

vyzo commented Apr 28, 2019

Stebalien left a comment

don't delete under the read lock #76

don't delete under the read lock #76

Conversation

vyzo commented Apr 28, 2019 • edited Loading

vyzo commented Apr 28, 2019

vyzo commented Apr 28, 2019

Stebalien left a comment

Choose a reason for hiding this comment

vyzo commented Apr 28, 2019 •

edited

Loading