This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Fix test flakes #164
Merged
Fix test flakes #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Jul 21, 2021
Stebalien
commented
- Don't run datastore tests in parallel.
- Avoid writing to disk, just test in-memory.
- Add some additional assertions to make debugging errors easier.
This test is flaking on windows when using the leveldb datastore. Hopefully, this extra check will help us narrow it down.
We have timing dependencies in some of these tests.
Makes the timing much less problematic, especially in CI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.