Skip to content

fix: flaky TestTableFindMultipleBuckets #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumemichel merged 1 commit into from
Feb 19, 2025
Merged

fix: flaky TestTableFindMultipleBuckets #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ func TestBucket(t *testing.T) {
t.Fatalf("split failed. found id with cpl == 0 in non 0 bucket")
}
}

}

func TestNPeersForCpl(t *testing.T) {
Expand Down Expand Up @@ -510,7 +509,6 @@ func TestTryAddPeer(t *testing.T) {
require.NotNil(t, p6)
require.True(t, pi.LastUsefulAt.IsZero())
rt.tabLock.Unlock()

}

func TestReplacePeerWithBucketSize1(t *testing.T) {
Expand Down Expand Up @@ -556,7 +554,6 @@ func TestMarkAllPeersIrreplaceable(t *testing.T) {
for i := range ps {
require.False(t, ps[i].replaceable)
}

}

func TestTableFindMultiple(t *testing.T) {
Expand Down Expand Up @@ -589,8 +586,9 @@ func TestTableFindMultipleBuckets(t *testing.T) {
rt, err := NewRoutingTable(5, ConvertPeerID(local), time.Hour, m, NoOpThreshold, nil)
require.NoError(t, err)

peers := make([]peer.ID, 100)
for i := 0; i < 100; i++ {
generatedPeerCount := 100
peers := make([]peer.ID, generatedPeerCount)
for i := 0; i < generatedPeerCount; i++ {
peers[i] = test.RandPeerIDFatal(t)
rt.TryAddPeer(peers[i], true, false)
}
Expand All @@ -601,9 +599,11 @@ func TestTableFindMultipleBuckets(t *testing.T) {

// should be able to find at least 30
// ~31 (logtwo(100) * 5)
found := rt.NearestPeers(ConvertPeerID(peers[2]), 20)
if len(found) != 20 {
t.Fatalf("asked for 20 peers, got %d", len(found))
targetNumberOfPeers := 20
found := rt.NearestPeers(ConvertPeerID(peers[2]), targetNumberOfPeers)
if len(found) != min(targetNumberOfPeers, rt.Size()) {
rt.Print()
t.Fatalf("asked for %d peers, got %d, rt size %d", targetNumberOfPeers, len(found), rt.Size())
}
for i, p := range found {
if p != closest[i] {
Expand All @@ -612,7 +612,7 @@ func TestTableFindMultipleBuckets(t *testing.T) {
}

// Ok, now let's try finding all of them.
found = rt.NearestPeers(ConvertPeerID(peers[2]), 100)
found = rt.NearestPeers(ConvertPeerID(peers[2]), generatedPeerCount)
if len(found) != rt.Size() {
t.Fatalf("asked for %d peers, got %d", rt.Size(), len(found))
}
Expand Down