tracing: fix DHT keys as string attribute not being valid utf-8 #859
Conversation
|
Ok nvm, having the conditional is fine, let's still use a multibase to encode it. |
| func KeyAsAttribute(name string, key string) attribute.KeyValue { | ||
| b := []byte(key) | ||
| if utf8.Valid(b) { | ||
| return attribute.String(name, key) | ||
| } | ||
| encoded, err := multibase.Encode(multibase.Base58BTC, b) | ||
| if err != nil { | ||
| // should be unreachable | ||
| panic(err) | ||
| } | ||
| return attribute.String(name, encoded) | ||
| } |
There was a problem hiding this comment.
I don't really like that we always run this code, even if we are not tracing. Might be something to do by returning an fmt.Stringer that lazily do this, however I belive otel always execute stringers anyway. The DHT is not very CPU efficient nor hot anyway so that fine, if it becomes not in profiles we should hoist this in some reusable package, send PR to lazily stringify in otel and return an fmt.Stringer.
|
Suggested version: Changes in (empty)
Automatically created GitHub ReleasePre-creating GitHub Releases on release PRs initiated from forks is not supported. |
Fix #858