Skip to content

fullrt: fix default values not applied on config#764

Closed
MichaelMure wants to merge 1 commit intolibp2p:masterfrom
MichaelMure:fullrt-default-config
Closed

fullrt: fix default values not applied on config#764
MichaelMure wants to merge 1 commit intolibp2p:masterfrom
MichaelMure:fullrt-default-config

Conversation

@MichaelMure
Copy link
Copy Markdown
Contributor

It looks like an oversight.

Without this, FullRT doesn't act as a drop-in replacement for IpfsDHT. Worse, those default values can't be reached as they are internals.

@MichaelMure
Copy link
Copy Markdown
Contributor Author

cc @aschmahmann

@aschmahmann
Copy link
Copy Markdown
Contributor

Discussed offline, I think we should be moving away from having the defaults be for the IPFS Public DHT since there are already a few networks out there.

Also, the FullRT client is not a drop-in replacement for the IpfsDHT client (added some docs in #768), so the idea that the options aren't quite a drop-in replacement doesn't seem so bad.

If we think it's helpful to have something like an IpfsDHTOptions function within the fullrt package to make it easier for folks to discover the relevant options I'm game for that though.

WDYT?

@MichaelMure
Copy link
Copy Markdown
Contributor Author

In that case, maybe a completely different set of options would be better? The current situation is quite confusing as a user as you don't know which options are supported and if their behavior differ. Not operating on the same default makes it also quite error prone.

Additionally, there should be an identical way to configure the network properties (bucket size ...).

@guillaumemichel
Copy link
Copy Markdown
Collaborator

Closing for inactivity, feel free to reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants