fullrt: fix default values not applied on config#764
fullrt: fix default values not applied on config#764MichaelMure wants to merge 1 commit intolibp2p:masterfrom
Conversation
|
cc @aschmahmann |
|
Discussed offline, I think we should be moving away from having the defaults be for the IPFS Public DHT since there are already a few networks out there. Also, the FullRT client is not a drop-in replacement for the IpfsDHT client (added some docs in #768), so the idea that the options aren't quite a drop-in replacement doesn't seem so bad. If we think it's helpful to have something like an WDYT? |
|
In that case, maybe a completely different set of options would be better? The current situation is quite confusing as a user as you don't know which options are supported and if their behavior differ. Not operating on the same default makes it also quite error prone. Additionally, there should be an identical way to configure the network properties (bucket size ...). |
|
Closing for inactivity, feel free to reopen if necessary |
It looks like an oversight.
Without this,
FullRTdoesn't act as a drop-in replacement forIpfsDHT. Worse, those default values can't be reached as they are internals.