fullrt rework batching #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
reviewed
Jun 8, 2021
gammazero
approved these changes
Jun 11, 2021
Removed divideIntoGroups Renamed divideIntoChunks into divideByChunkSize Reworked tests to target divideByChunkSize instead of divideIntoGroups Fixed divideByChunkSize to pass tests Made divideByChunkSize handle the cases of empty key lists and panic on invalid chunk sizes
aschmahmann
force-pushed
the
exp/fullrt-rework-batching
branch
from
af6797d
to
dae2082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked full batching so that it's more explicitly peer oriented rather than key oriented.
There's still room for improvement here on dealing with slow peers (e.g. having more message-based rather than peer-based parallelism).
Some tests on a 2 core machine with about 800k CIDs being provided (after a fresh crawl, although that is hopefully not super relevant)