Disallow GetPublicKey when DisableValues is passed #604
Conversation
dht_options.go
Outdated
|
|
||
| if !c.enableValues { | ||
| c.validator = nil | ||
| } |
There was a problem hiding this comment.
@Stebalien do you think this is worth doing or no? We have some tests and I've done a once-over and it looks like we shouldn't have any problems with nil validators if enableValues=false, if it's enableValues=true though is it fair to say the developer has shot themselves in the foot or should we throw in a bunch of nil checks or implement a NilValidator that's applied here in the fallbacks.
There was a problem hiding this comment.
Why not just leave the validator?
There was a problem hiding this comment.
I guess no particular reason, it's not like it's going to eat up much memory. This was more a point for discussing what we should do around nil validators.
I'll remove those few lines and merge.
dht_options.go
Outdated
|
|
||
| if !c.enableValues { | ||
| c.validator = nil | ||
| } |
There was a problem hiding this comment.
Why not just leave the validator?
petar
force-pushed
the
fix/disable-values-option
branch
from
57ffb53
to
b95fd5d
Compare
…ic keys (i.e. the /pk namespace)
aschmahmann
force-pushed
the
fix/disable-values-option
branch
from
b95fd5d
to
d5d5a9e
Compare
|
This is missing a test to confirm the new behavior, but is otherwise ready |
|
Let's not leave it in a PR. |
No description provided.