Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: fix error "leak" #328

Merged
merged 1 commit into from
Apr 24, 2019
Merged

query: fix error "leak" #328

merged 1 commit into from
Apr 24, 2019

Conversation

Stebalien
Copy link
Member

Long-running queries can build up large error sets that we never actually use.
This is exacerbated by libp2p/go-libp2p-swarm#115.

fixes libp2p/go-libp2p-swarm#119

@ghost ghost assigned Stebalien Apr 24, 2019
@ghost ghost added the status/in-progress In progress label Apr 24, 2019
@Stebalien Stebalien requested a review from raulk April 24, 2019 15:33
Long-running queries can build up large error sets that we never actually use.
This is exacerbated by libp2p/go-libp2p-swarm#115.

fixes libp2p/go-libp2p-swarm#119
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This removes unnecessary complexity while achieving a similar result.

@Stebalien Stebalien merged commit 080cd52 into master Apr 24, 2019
@Stebalien Stebalien deleted the fix/error-leak branch April 24, 2019 16:08
@ghost ghost removed the status/in-progress In progress label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaking dial errors
3 participants