fix: use correct message type attribute in metrics#1076
Merged
guillaumemichel merged 1 commit intolibp2p:masterfrom Apr 24, 2025
Merged
fix: use correct message type attribute in metrics#1076guillaumemichel merged 1 commit intolibp2p:masterfrom
guillaumemichel merged 1 commit intolibp2p:masterfrom
Conversation
guillaumemichel
approved these changes
Apr 24, 2025
Collaborator
guillaumemichel
left a comment
guillaumemichel
left a comment
There was a problem hiding this comment.
LGTM, thanks @diogo464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message type attribute was being overwritten with "UNKNOWN" because
attrOptwas given afterattrSetOpt(which contained the message type from the context) in the varargs.I removed the message type "UNKOWN" from
RecordRequestSendOKsince its only called once and the context that is passed in has the message type attribute set.The images bellow show the problem with an example query in victoria metrics.
