Skip to content

tests: fix flaky TestProvidesExpire #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumemichel merged 1 commit into from
Mar 19, 2025
+4 −4
Merged

tests: fix flaky TestProvidesExpire #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions providers/providers_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func TestProvidesExpire(t *testing.T) {
pval := ProvideValidity
cleanup := defaultCleanupInterval
ProvideValidity = time.Second / 2
defaultCleanupInterval = time.Second / 2
defaultCleanupInterval = time.Second / 10
defer func() {
ProvideValidity = pval
defaultCleanupInterval = cleanup
Expand Down Expand Up @@ -181,7 +181,7 @@ func TestProvidesExpire(t *testing.T) {
p.AddProvider(ctx, h, peer.AddrInfo{ID: peers[1]})
}

time.Sleep(time.Second / 4)
time.Sleep(ProvideValidity / 2)

for _, h := range mhs[5:] {
p.AddProvider(ctx, h, peer.AddrInfo{ID: peers[0]})
Expand All @@ -195,7 +195,7 @@ func TestProvidesExpire(t *testing.T) {
}
}

time.Sleep(3 * time.Second / 8)
time.Sleep(ProvideValidity/2 + 2*defaultCleanupInterval)

for _, h := range mhs[:5] {
out, _ := p.GetProviders(ctx, h)
Expand All @@ -211,7 +211,7 @@ func TestProvidesExpire(t *testing.T) {
}
}

time.Sleep(time.Second / 2)
time.Sleep(ProvideValidity)

// Stop to prevent data races
p.Close()
Expand Down