Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

remove dependency on the go-libp2p-peerstore/addr package #79

Closed
wants to merge 1 commit into from

Conversation

marten-seemann
Copy link
Contributor

This code, as the previous code, assume that the addresses in peer.AddrInfo are unique (in subtly different ways).

Needed for libp2p/go-libp2p-peerstore#181.

Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn'tnecessarily safe assumption to make; veey often these addrs come from the network.

But what can go wrong in that case? Maybe it is totally fine to remove this check and get a slight speedup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants