Fix hang in BackoffDiscovery.FindPeers when requesting limit lower than number of peers available #69
Conversation
…an number of peers available
| select { | ||
| case pch <- ai: | ||
| default: | ||
| // skip if we have asked for a lower limit than the number of peers known |
There was a problem hiding this comment.
I'm wondering if it's ok here to return more than options.Limit values. The consumer could rely on this limit, as it's documented here:
https://github.com/libp2p/go-libp2p-core/blob/525a0b13017263bde889a3295fa2e4212d7af8c5/discovery/options.go#L35-L41
There was a problem hiding this comment.
Can you clarify your comment, it seems ambiguous and I am not sure if you are asking if it's ok to do something different to this code or if this code is ok as is. This code respects the limit by skipping any that exceed the number requested.
There was a problem hiding this comment.
Sorry, I don't understand any more what I was saying 4 weeks ago either ;)
|
@iand : can you please incorporate comments so we can get this merged? |
|
@marten-seemann : can you please merge this and get it bubbled to go-ipfs? |
Fixes #67