This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
switch to the go-crypto ed25519 implementation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
changed the title
Also correctly parse private keys that don't have a redundant public key appended. This commit doesn't change the *serialization* format for backwards compatibility but we can now do that in the future (once most users are using this version). This *does* remove the `ToCurve25519` function as it's not in the standard library. However: 1. Nobody's using it. 2. Users can always extract the serialized key and do this themselves (by calling `Raw()`).
dignifiedquire
approved these changes
Aug 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correctly parse private keys that don't have a redundant public key appended. This commit doesn't change the serialization format for backwards compatibility but we can now do that in the future (once most users are using this version).
This does remove the
ToCurve25519function as it's not in the standard Library. However:Raw()).