This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
remove flaky tests #194
Merged
remove flaky tests #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests regularly failed to stay within the 1% of the expected threshold. These tests are taken after 2.1 seconds on the wall, but before the wait-group has finished, but I think on many systems the timers are not accurate to be used reliabily within tight
On my system (kernel configured with CONFIG_HZ=300) each tick may be inaccurate by more than 3ms, over 40 iterations the error might be as high as 1.6% for each goroutine
I chose to delete these tests because figuring out the right error threashold seems a little too magical to me, but if there's a good reason to keep these tests I can change htis PR to just increase the error threshold.