Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

remove flaky tests #194

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

coryschwartz
Copy link
Contributor

These tests regularly failed to stay within the 1% of the expected threshold. These tests are taken after 2.1 seconds on the wall, but before the wait-group has finished, but I think on many systems the timers are not accurate to be used reliabily within tight

On my system (kernel configured with CONFIG_HZ=300) each tick may be inaccurate by more than 3ms, over 40 iterations the error might be as high as 1.6% for each goroutine

I chose to delete these tests because figuring out the right error threashold seems a little too magical to me, but if there's a good reason to keep these tests I can change htis PR to just increase the error threshold.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair enough. I've fought with these tests for hours in the past.

@Stebalien Stebalien merged commit 525a0b1 into libp2p:master Apr 15, 2021
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants