Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Phobos version of staticIsSorted that uses alias assign #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nordlow
Copy link
Contributor

@nordlow nordlow commented Oct 24, 2022

Reduces number of template instances of staticIsSorted from log2(items.length) to 1.

This is the first in a set of MRs to reduce compile-time complexity of TypeSet.

Alias assignment is available since 2.098.0..

I have no idea why this triggers

source/mir/algebraic.d(378,17): Error: alias `mir.algebraic.TypeSet!(typeof(null), double, S).TypeSet` recursive alias declaration

. Compiler bug, @9il?

@nordlow nordlow force-pushed the use-alias-assign-in-staticIsSorted branch from 0ab1c70 to 6f18aec Compare October 24, 2022 13:12
@nordlow
Copy link
Contributor Author

nordlow commented Nov 14, 2022

Ping, @9il. This ready.

…iling with compiler version => 2.098.0

Reduces number of template instances of staticIsSorted from log(items.length) to 1
@nordlow nordlow force-pushed the use-alias-assign-in-staticIsSorted branch from 6f18aec to 449328a Compare December 5, 2022 21:42
@nordlow
Copy link
Contributor Author

nordlow commented Dec 5, 2022

There's an issue with staticIsSorted not matching staticSort. Will need to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant