Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use onRangeError in StringMap.opIndex #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nordlow
Copy link
Contributor

@nordlow nordlow commented Dec 9, 2021

For the sake of having StringMap.opIndex behave like AA.opIndex and be nothrow @nogc.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #386 (99c812f) into master (b21ff32) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   93.04%   92.83%   -0.22%     
==========================================
  Files          65       65              
  Lines       15891    15927      +36     
==========================================
  Hits        14786    14786              
- Misses       1105     1141      +36     
Impacted Files Coverage Δ
source/mir/string_map.d 95.15% <0.00%> (-0.25%) ⬇️
source/mir/interpolate/constant.d 71.42% <0.00%> (-15.53%) ⬇️
source/mir/interpolate/generic.d 71.42% <0.00%> (-11.91%) ⬇️
source/mir/rc/slim_ptr.d 69.01% <0.00%> (-7.55%) ⬇️
source/mir/rc/ptr.d 76.92% <0.00%> (-6.42%) ⬇️
source/mir/interpolate/linear.d 90.80% <0.00%> (-5.54%) ⬇️
source/mir/interpolate/spline.d 91.70% <0.00%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21ff32...99c812f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants