Skip to content

Make gflags an IMPORTED GLOBAL library#1234

Merged
sboukortt merged 1 commit intolibjxl:mainfrom
amyspark:amyspark/gflags
Apr 19, 2022
Merged

Make gflags an IMPORTED GLOBAL library#1234
sboukortt merged 1 commit intolibjxl:mainfrom
amyspark:amyspark/gflags

Conversation

@mo271
Copy link
Member

mo271 commented Mar 23, 2022

Thanks for the contribution! Could you add your name to the AUTHORS file (keeping alphabetical order..)?

mo271
mo271 previously requested changes Mar 25, 2022
@mo271
Copy link
Member

mo271 commented Mar 25, 2022

Thanks for modifying AUTHORS! This check is green now.

@mo271 mo271 added this to the 1.0 version milestone Apr 8, 2022
@sboukortt sboukortt dismissed mo271’s stale review April 13, 2022 13:29

Change applied

@sboukortt sboukortt enabled auto-merge (rebase) April 13, 2022 13:30
@sboukortt
Copy link
Member

Thanks!

@amyspark amyspark requested a review from sboukortt April 14, 2022 00:14
@sboukortt sboukortt merged commit ca1aa63 into libjxl:main Apr 19, 2022
@jonsneyers
Copy link
Member

This broke something for the Release linux x86_64 static build:

[288/310] Linking CXX executable tools/cjxl_ng
FAILED: tools/cjxl_ng 
: && /usr/bin/clang++ -ffunction-sections -fdata-sections -fno-rtti -funwind-tables -Xclang -mrelax-all -Xclang -mconstructor-aliases -fno-omit-frame-pointer -O3 -DNDEBUG -O2 -Wl,--gc-sections -Wl,--no-export-dynamic -static -static-libgcc -static-libstdc++    -fPIE -pie tools/CMakeFiles/cjxl_ng.dir/cjxl_ng_main.cc.o -o tools/cjxl_ng  lib/libjxl.a  lib/libjxl_extras_dec-static.a  lib/libjxl_threads.a  third_party/highway/libhwy.a  /usr/lib/x86_64-linux-gnu/libgflags.so.2.2.2  tools/box/libbox.a  lib/libjxl.a  lib/libjxl_extras-static.a  lib/libjxl_threads.a  tools/libjxl_tool.a  lib/libjxl_extras_dec-static.a  /usr/lib/x86_64-linux-gnu/libgif.a  /usr/lib/x86_64-linux-gnu/libjpeg.a  /usr/lib/x86_64-linux-gnu/libpng.a  /usr/lib/x86_64-linux-gnu/libz.a  third_party/sjpeg/libsjpeg.a  lib/libjxl.a  third_party/highway/libhwy.a  third_party/brotli/libbrotlidec-static.a  -lpthread  -Wl,--whole-archive  -Wl,--no-whole-archive  third_party/brotli/libbrotlienc-static.a  third_party/brotli/libbrotlicommon-static.a  -lm && :
clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument]
/usr/bin/ld: attempted static link of dynamic object `/usr/lib/x86_64-linux-gnu/libgflags.so.2.2.2'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@mo271
Copy link
Member

mo271 commented Apr 25, 2022

This broke something for the Release linux x86_64 static build:

[288/310] Linking CXX executable tools/cjxl_ng
FAILED: tools/cjxl_ng 
: && /usr/bin/clang++ -ffunction-sections -fdata-sections -fno-rtti -funwind-tables -Xclang -mrelax-all -Xclang -mconstructor-aliases -fno-omit-frame-pointer -O3 -DNDEBUG -O2 -Wl,--gc-sections -Wl,--no-export-dynamic -static -static-libgcc -static-libstdc++    -fPIE -pie tools/CMakeFiles/cjxl_ng.dir/cjxl_ng_main.cc.o -o tools/cjxl_ng  lib/libjxl.a  lib/libjxl_extras_dec-static.a  lib/libjxl_threads.a  third_party/highway/libhwy.a  /usr/lib/x86_64-linux-gnu/libgflags.so.2.2.2  tools/box/libbox.a  lib/libjxl.a  lib/libjxl_extras-static.a  lib/libjxl_threads.a  tools/libjxl_tool.a  lib/libjxl_extras_dec-static.a  /usr/lib/x86_64-linux-gnu/libgif.a  /usr/lib/x86_64-linux-gnu/libjpeg.a  /usr/lib/x86_64-linux-gnu/libpng.a  /usr/lib/x86_64-linux-gnu/libz.a  third_party/sjpeg/libsjpeg.a  lib/libjxl.a  third_party/highway/libhwy.a  third_party/brotli/libbrotlidec-static.a  -lpthread  -Wl,--whole-archive  -Wl,--no-whole-archive  third_party/brotli/libbrotlienc-static.a  third_party/brotli/libbrotlicommon-static.a  -lm && :
clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument]
/usr/bin/ld: attempted static link of dynamic object `/usr/lib/x86_64-linux-gnu/libgflags.so.2.2.2'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Seems to be fixed here #1364

@amyspark amyspark deleted the amyspark/gflags branch October 28, 2022 14:26
@mo271 mo271 added the v1.0 label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing libraries via thirdparty makes libjxl impossible to build on Windows

4 participants