Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation #659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Localisation #659

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46c025e
use better location for the .lproj files and add (still empty) german…
schriftgestalt Jul 20, 2018
e5fe4c6
add target to update the english Localizable.strings
schriftgestalt Jul 20, 2018
5914da5
WIP: add NSLocalizedString macros
schriftgestalt Jul 20, 2018
a236c12
remove code signing info
schriftgestalt Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions ObjectiveGitFramework.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@
objects = {

/* Begin PBXAggregateTarget section */
562126272101D971009A787A /* genstrings */ = {
isa = PBXAggregateTarget;
buildConfigurationList = 5621262C2101D971009A787A /* Build configuration list for PBXAggregateTarget "genstrings" */;
buildPhases = (
5621262D2101D978009A787A /* ShellScript */,
);
dependencies = (
);
name = genstrings;
productName = genstrings;
};
6A28265217C69CB400C6A948 /* OpenSSL-iOS */ = {
isa = PBXAggregateTarget;
buildConfigurationList = 6A28265417C69CB400C6A948 /* Build configuration list for PBXAggregateTarget "OpenSSL-iOS" */;
Expand Down Expand Up @@ -1290,6 +1301,11 @@
LastUpgradeCheck = 0930;
ORGANIZATIONNAME = "GitHub, Inc";
TargetAttributes = {
562126272101D971009A787A = {
CreatedOnToolsVersion = 9.4.1;
DevelopmentTeam = X2L8375ZQ7;
ProvisioningStyle = Automatic;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted codesigning hunk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed that. Thanks

88F05A6A16011E5400B7AD1D = {
LastSwiftMigration = 0830;
};
Expand Down Expand Up @@ -1329,6 +1345,7 @@
D0A330F216027F3600A616FA /* libgit2-iOS */,
6A28265217C69CB400C6A948 /* OpenSSL-iOS */,
6A3C609017D5963700382DFF /* libssh2-iOS */,
562126272101D971009A787A /* genstrings */,
);
};
/* End PBXProject section */
Expand Down Expand Up @@ -1364,6 +1381,19 @@
/* End PBXResourcesBuildPhase section */

/* Begin PBXShellScriptBuildPhase section */
5621262D2101D978009A787A /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /usr/bin/python;
shellScript = "# encoding=utf-8\n\nimport os, time, codecs\nroot = os.getenv('SRCROOT')\nprint \"update localisation in\", root\nfor (dirpath, dirnames, filenames) in os.walk(root):\n if \"en.lproj\" in dirnames:\n os.chdir(dirpath)\n os.system(\"find ./ -name '*.mm' -o -name '*.m' | xargs genstrings -u -q -o en.lproj\")\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split that into ./script/update-localization ? That would be ❤️, as that would save my soul from Xcode make it much easier to edit.

};
6A28265317C69CB400C6A948 /* OpenSSL-iOS */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -1830,6 +1860,42 @@
};
name = Release;
};
562126282101D971009A787A /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = X2L8375ZQ7;
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Debug;
};
562126292101D971009A787A /* Test */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = X2L8375ZQ7;
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Test;
};
5621262A2101D971009A787A /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = X2L8375ZQ7;
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Release;
};
5621262B2101D971009A787A /* Profile */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = X2L8375ZQ7;
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Profile;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hunk should be left out — that's codesigning configuration.

6A28265517C69CB400C6A948 /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = D0D81865174421EB00995A2E /* iOS-StaticLibrary.xcconfig */;
Expand Down Expand Up @@ -2494,6 +2560,17 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
5621262C2101D971009A787A /* Build configuration list for PBXAggregateTarget "genstrings" */ = {
isa = XCConfigurationList;
buildConfigurations = (
562126282101D971009A787A /* Debug */,
562126292101D971009A787A /* Test */,
5621262A2101D971009A787A /* Release */,
5621262B2101D971009A787A /* Profile */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
6A28265417C69CB400C6A948 /* Build configuration list for PBXAggregateTarget "OpenSSL-iOS" */ = {
isa = XCConfigurationList;
buildConfigurations = (
Expand Down