-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap git_index_add_all #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks good at a first glance. Could you add some simple tests for this? You could copy one of the existing ones, just add more than 1 file to it.
Sure, I just thought the test suite is ignored on this project. |
I look at it. We "just" have one failing test on macOS which is consistent 😆. iOS is a different story. |
Yeah, would be great if all the tests worked... But I do too see the value in testing. I'll probably get around to the tests this weekend. |
Yeah, many people have spent many hours trying to fix the tests. Thanks a lot! No pressure from my side 😅 |
#599 has a green iOS build, but it is already 5 months old. |
Let's see what https://travis-ci.org/libgit2/objective-git/builds/237270148 brings. |
@pietbrauer Thanks for fixing the build! 👍 |
I added a small test. |
Allows the user to do something like
git add -A