Exposing line info from git_diff_hunk in GTDiffHunk. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,18 @@ NS_ASSUME_NONNULL_BEGIN | |||
| /// The number of lines represented in the hunk. | |||
| @property (nonatomic, readonly) NSUInteger lineCount; | |||
|
|
|||
| // The starting line number in the old file | |||
There was a problem hiding this comment.
Please use triple forward slashes for the documentation comments
|
Just a documentation issue else I am fine with this. Could you rebase your commits afterwards? |
dougfales
force-pushed
the
expose-git-diff-hunk-line-info
branch
from
886a41d to
8389858
Compare
dougfales
force-pushed
the
expose-git-diff-hunk-line-info
branch
from
8389858 to
ddd558b
Compare
|
Thanks @pietbrauer! I've updated the comments and rebased. Let me know if there's anything else I can do. |
|
Superb, thanks! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see how to get at these fields in the underlying
git_diff_hunk, so I copied them into obj-c properties onGTDiffhunk. I'm not really sure if that's the right way to do it–if you'd prefer I pass through to thegit_diff_hunkor if there's some other way that I'm missing.I updated the hunk-related spec in
GTDiffSpec.mbecause I didn't see any test files dedicated specifically toGTDiffHunk.