-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix super slow iOS Tests #555
Conversation
af44e6c
to
ad0a3f5
Compare
This is amazingly faster. Nice work! Had one snag when running
It looks like checking out the This was due to having an older ZipArchive checkout which left behind the |
Yeah, SSZipArchive is a bit weird but we use the files directly. |
Will remove the file reference. |
Looks like |
Updated SSZipArchive |
a2abb8c
to
a387dbd
Compare
Can't update to 1.1 because it has a lot of warnings. Staying on 1.0.1 but remove the reference to the project. |
Sounds good to me! |
Updates dependencies to Nimble, Quick and SSZipArchive.
iOS Tests were running super slow (30 minutes total) this was because after every single test case the unzipped fixture repository would be deleted from disk and unzipped again from the 28MB big zip file. This was not an issue on Mac as
unzip
super fast (apparently) butSSZipArchive
cannot quite keep up and so every single iOS test case would take 5-7 seconds to unzip + the time the test needs to run.What I did is just unzip it once and store it in a directory called
clean_repository
, the directory is still removed after each test but instead of unzipping again I just copy the desired repository into its place not touching theclean_repository
.