Added support for git_cred_ssh_key_memory_new GTCredentials #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added +[GTCredential credentialWithUserName:publicKeyString:privateKeyString:passphrase:error:] to support libgit2 git_cred_ssh_key_memory_new() credentials.
| @@ -74,6 +74,18 @@ NS_ASSUME_NONNULL_BEGIN | |||
| /// Return a new GTCredential instance, or nil if an error occurred | |||
| + (nullable instancetype)credentialWithUserName:(NSString *)userName publicKeyURL:(nullable NSURL *)publicKeyURL privateKeyURL:(NSURL *)privateKeyURL passphrase:(nullable NSString *)passphrase error:(NSError **)error; | |||
|
|
|||
| /// Create a credential object from a SSH keyfile data string | |||
| /// | |||
| /// userName - The username to authenticate as. Must not be nil. | |||
There was a problem hiding this comment.
Happily I think we can stop writing nilability in the comments, since nullable indicates it!
There was a problem hiding this comment.
I agree; but I tried to follow whatever was in the similar function above :)
There was a problem hiding this comment.
Yeah, that's always the best route to take! But happily standards change.
|
This looks great, thanks! Just a couple nits to pick. |
Fixed indentation on one of the lines (was a tad off); Removed references to nilability as nullable keyword indicates that. Didn't touch other functions I didn't author.
|
There you go. :) |
|
🤘 |
joshaber
added a commit
that referenced
this pull request
Aug 13, 2015
Added support for git_cred_ssh_key_memory_new GTCredentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added +[GTCredential credentialWithUserName:publicKeyString:privateKeyString:passphrase:error:] to support libgit2 git_cred_ssh_key_memory_new() credentials.