Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give extern'd string known nullability. #479

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Give extern'd string known nullability. #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ObjectiveGit/GTDiff.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
@class GTRepository;
@class GTTree;

NS_ASSUME_NONNULL_BEGIN

/// An `NSNumber` wrapped `GTDiffOptionsFlags` representing any flags you wish to
/// pass into the initialisation.
extern NSString *const GTDiffOptionsFlagsKey;
Expand Down Expand Up @@ -172,8 +174,6 @@ typedef NS_OPTIONS(NSInteger, GTDiffFindOptionsFlags) {
GTDiffFindOptionsFlagsBreakRewritesForRenamesOnly = GIT_DIFF_BREAK_REWRITES_FOR_RENAMES_ONLY,
};

NS_ASSUME_NONNULL_BEGIN

/// A class representing a single "diff".
///
/// Analagous to `git_diff_list` in libgit2, this object represents a list of
Expand Down
4 changes: 2 additions & 2 deletions ObjectiveGit/GTFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
@class GTRepository;
@class GTFilterSource;

NS_ASSUME_NONNULL_BEGIN

/// The error domain for errors originating from GTFilter.
extern NSString * const GTFilterErrorDomain;

/// A filter with that name has already been registered.
extern const NSInteger GTFilterErrorNameAlreadyRegistered;

NS_ASSUME_NONNULL_BEGIN

/// Git filter abstraction.
///
/// **Note**: GTFilter is *not* thread safe. Registration and unregistration
Expand Down
4 changes: 2 additions & 2 deletions ObjectiveGit/GTRemote.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
@class GTReference;
@class GTCredentialProvider;

NS_ASSUME_NONNULL_BEGIN

extern NSString * const GTRemoteRenameProblematicRefSpecs;

// Auto Tag settings. See `git_remote_autotag_option_t`.
Expand All @@ -23,8 +25,6 @@ typedef enum {
GTRemoteDownloadTagsAll = GIT_REMOTE_DOWNLOAD_TAGS_ALL,
} GTRemoteAutoTagOption;

NS_ASSUME_NONNULL_BEGIN

/// A class representing a remote for a git repository.
///
/// Analogous to `git_remote` in libgit2.
Expand Down
4 changes: 2 additions & 2 deletions ObjectiveGit/GTRepository+RemoteOperations.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@

@class GTFetchHeadEntry;

NS_ASSUME_NONNULL_BEGIN

/// A `GTCredentialProvider`, that will be used to authenticate against the remote.
extern NSString *const GTRepositoryRemoteOptionsCredentialProvider;

NS_ASSUME_NONNULL_BEGIN

@interface GTRepository (RemoteOperations)

#pragma mark - Fetch
Expand Down
4 changes: 2 additions & 2 deletions ObjectiveGit/GTRepository+Status.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

@class GTStatusDelta;

NS_ASSUME_NONNULL_BEGIN

/// An enum representing the status of a file
/// See git_status_t
typedef NS_OPTIONS(NSInteger, GTFileStatusFlags) {
Expand Down Expand Up @@ -81,8 +83,6 @@ typedef enum {
/// Defaults to including all files.
extern NSString *const GTRepositoryStatusOptionsPathSpecArrayKey;

NS_ASSUME_NONNULL_BEGIN

@interface GTRepository (Status)

/// `YES` if the working directory has no modified, new, or deleted files.
Expand Down
4 changes: 2 additions & 2 deletions ObjectiveGit/GTRepository.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
@class GTTree;
@class GTRemote;

NS_ASSUME_NONNULL_BEGIN

/// Checkout strategies used by the various -checkout... methods
/// See git_checkout_strategy_t
typedef NS_OPTIONS(NSInteger, GTCheckoutStrategyType) {
Expand Down Expand Up @@ -148,8 +150,6 @@ extern NSString * const GTRepositoryInitOptionsInitialHEAD;
/// initialization.
extern NSString * const GTRepositoryInitOptionsOriginURLString;

NS_ASSUME_NONNULL_BEGIN

@interface GTRepository : NSObject

/// The file URL for the repository's working directory.
Expand Down