Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NS_UNAVAILABLE flag to all unneeded super initializers (NSObject init) #477

Conversation

javiertoledo
Copy link
Contributor

I think that this fix is better than the previously submitted in #476, as XCode marks init usages as “unavailable” and, if for some reason an init call is achieved in runtime, it raises a runtime error via NSAssert.

@mdiep
Copy link
Contributor

mdiep commented Jul 5, 2015

This looks like the right fix to me.

@phatblat
Copy link
Member

phatblat commented Jul 5, 2015

👍

@joshaber joshaber self-assigned this Jul 6, 2015
@joshaber
Copy link
Member

joshaber commented Jul 6, 2015

This is great, thanks so much!

joshaber added a commit that referenced this pull request Jul 6, 2015
…sense-for-xcode7-complains

Added NS_UNAVAILABLE flag to all unneeded super initializers (NSObject init)
@joshaber joshaber merged commit 083a733 into libgit2:master Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants