Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling tag enumerator block if lookup returns nil tag #462

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Avoid calling tag enumerator block if lookup returns nil tag #462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f5730d
Avoid calling tag enumerator block if lookup returns nil tag
dleehr Jun 2, 2015
4f29c2b
Explicitly compare tag to nil, per style recommendation
dleehr Jun 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ObjectiveGit/GTRepository.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,9 @@ static int GTRepositoryForeachTagCallback(const char *name, git_oid *oid, void *
GTTag *tag = (GTTag *)[info->myself lookUpObjectByGitOid:oid objectType:GTObjectTypeTag error:NULL];

BOOL stop = NO;
info->block(tag, &stop);
if (tag != nil) {
info->block(tag, &stop);
}

return stop ? GIT_EUSER : 0;
}
Expand Down