Add ability to cancel the remote part of the clone operation #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the transferProgressBlock look more like its libgit equivalent the git_transfer_progress_cb.
|
I don't know whether it is worth introducing a breaking change for such a small |
|
Thanks! I think it's a great idea to be able to cancel the transfer, but I think it'd be more idiomatic in Objective-C for the block to set a stop argument. E.g., transferProgressBlock:(void (^)(const git_transfer_progress *, BOOL *stop))transferProgressBlock |
|
+1 for |
Now the remote operation is cancelled via a stop parameter instead of a negative return value.
|
I think this should do the trick |
|
Awesome, thanks @alehed! |
joshaber
added a commit
that referenced
this pull request
Feb 4, 2015
Add ability to cancel the remote part of the clone operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the transferProgressBlock look more like its libgit equivalent
the git_transfer_progress_cb.