Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out new binaries package #2064

Closed
wants to merge 5 commits into from
Closed

Try out new binaries package #2064

wants to merge 5 commits into from

Conversation

bording
Copy link
Member

@bording bording commented Nov 4, 2023

No description provided.

@bording
Copy link
Member Author

bording commented Nov 25, 2023

@ethomson This PR is trying out updating to libgit2 1.7.1 (previously on 1.6.4), but I'm seeing some potentially unexpected new behavior.

One of the tests I've already changed in this PR since it appears libgit2 is returning extensions in a new order.

However, the other tests are failing to due changes in the number of tags that are being fetched when the tag fetch mode is either not configured or set to auto.

I'm guessing this is related to libgit2/libgit2#6539, but I can't tell if this is an expected behavior change or some sort of bug. In at least one of the failures, it seems like doing the equivalent thing in git itself matches the old behavior that the tests were written against, and not what I'm seeing with 1.7.1.

@bording
Copy link
Member Author

bording commented Nov 26, 2023

Aha, I figured it out! Looks like the shallow clone support in 1.7.0 changed git_fetch_options to add the depth value.

After adding that, looks like everything is green now.

@ethomson It would probably be a good idea to update the libgit2 v1.7.0 release notes to add that info to the breaking changes section.

@bording
Copy link
Member Author

bording commented Nov 27, 2023

Closing this PR in favor of #2066

@bording bording closed this Nov 27, 2023
@bording bording deleted the test-new-binaries branch November 27, 2023 02:30
@ethomson
Copy link
Member

ethomson commented Dec 4, 2023

Thanks, sorry about that. Indeed that's a breaking ABI change. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants