Set BasicAuth in http.go only if username and password are not empty #914

clns · 2022-04-21T03:44:48Z

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt
is unsuccessful, any subsequent requests after calling the CredentialsCallback
will attempt to read/write on a closed pipe.

This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe.

…914) This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe. (cherry picked from commit 9db5de1)

lhchavez approved these changes Jul 13, 2022

View reviewed changes

lhchavez merged commit 9db5de1 into libgit2:main Jul 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set BasicAuth in http.go only if username and password are not empty #914

Set BasicAuth in http.go only if username and password are not empty #914

clns commented Apr 21, 2022

Set BasicAuth in http.go only if username and password are not empty #914

Set BasicAuth in http.go only if username and password are not empty #914

Conversation

clns commented Apr 21, 2022