-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Engine.java #313
base: master
Are you sure you want to change the base?
Update Engine.java #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No damage , so its ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the Gradle changes, this looks good.
group 'com.badlogicgames.ashley' | ||
version '1.7.5' | ||
|
||
jar { | ||
manifest { | ||
attributes 'Implementation-Title': 'ashley', | ||
'Implementation-Version': version | ||
} | ||
from { | ||
configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) } | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be part of the PR.
Extract the update system code from the update section of the Engine class to enhance Engine in subclasses. For example, multi-threaded Entity System execution.