Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Engine.java #313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Engine.java #313

wants to merge 2 commits into from

Conversation

zqll4
Copy link

@zqll4 zqll4 commented Jun 26, 2023

Extract the update system code from the update section of the Engine class to enhance Engine in subclasses. For example, multi-threaded Entity System execution.

Copy link
Contributor

@fabiitch fabiitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No damage , so its ok

Copy link
Member

@crykn crykn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the Gradle changes, this looks good.

Comment on lines +15 to +27
group 'com.badlogicgames.ashley'
version '1.7.5'

jar {
manifest {
attributes 'Implementation-Title': 'ashley',
'Implementation-Version': version
}
from {
configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) }
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be part of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants