MNT: migrate static metadata out of setup.cfg - #145
Conversation
|
I missed that |
dd5caa4 to
e38246a
Compare
e38246a to
e4ad476
Compare
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
A few small suggestions, which we might as well fix up...
|
|
||
| [tool.pytest.ini_options] | ||
| minversion = "4.6" | ||
| testpaths = ['"erfa"', '"docs"', '"README.rst"'] |
There was a problem hiding this comment.
I don't think this needs the single+double quotes -- at least, astropy just has the double ones.
| from warnings import warn | ||
|
|
||
| try: | ||
| from setuptools_scm import git, Configuration, get_version as _get_version |
There was a problem hiding this comment.
I'm a bit confused why this is needed, given that astropy has the simpler direct try/except that we had here. What other attribute is being gotten that the __getattr__ solves? Or is it just that timing now is different?
There was a problem hiding this comment.
I didn't have any recollection of it, luckilly the answer to your question is in the commit message:
RFC: refactor scm_version.py to survive pytest collection if setuptools_scm isn't installed
There was a problem hiding this comment.
So, isn't the answer then to ensure that pytest doesn't look at this directory? Is that what astropy does?
There was a problem hiding this comment.
I don't know. I couldn't reproduce the problem I was trying to solve here so I just reverted the change. The PR is more self-contained as a result.
41cfa7a to
65619a0
Compare
3 participants
Follow up to #144
migration from
setup.cfgtopyproject.tomlwas mostly automated usingini2toml