Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Sanitation Incompatibility #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatthewHartley
Copy link

When running the tutorial project while compiling with clang v18.1.8's memory sanitizer, the result is a panic in the ppack() function for writing unitialized memory with fwrite(). Manual inspection tells me that the memory in question is in fact initialized, and valgrind confirms that there is no use of unitialized memory, so this is ultimately an issue with clang's memory sanitizer, but is nonetheless annoying. I have confirmed that setting all the memory allocated in emalloc() to 0xAA (or any other value) fixes this issue, however if memory is allocated in erealloc(), I was able to confirm that the same issue would occur, and making erealloc() capable of initializing all the excess memory required me to change the signature of the function, which might be a breaking change.

… clang's memory sanitizer doesn't exit due to these allocations. changed function signature of erealloc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant