Avoid using generated va_list type #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielocfb
approved these changes
Mar 26, 2024
When using libbpf-sys' bindgen feature, the generated va_list type varies on different platforms. Use void pointer as va_list pointer type and transmute pointer of type that uses va_list pointer for cross platform support. See rust-lang/rust-bindgen#2631
|
Thanks again! |
danielocfb
pushed a commit
that referenced
this pull request
Mar 26, 2024
Add a CHANGELOG entry for #741, which fixed a function signature mismatch causing compilation failure in certain cross-compilation contexts. Signed-off-by: Daniel Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using libbpf-sys' bindgen feature, the generated va_list type varies on different platforms.
Use void pointer as va_list pointer type and transmute pointer of type use va_list pointer instead for cross platform support.
See rust-lang/rust-bindgen#2631