Skip to content

Conversation

@insearchoflosttime
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems sensible to me. Thanks! I am just wondering whether we should add a doc comment providing more details on what the method does, as it seems to be publicly accessible by users. What do you think?

@insearchoflosttime
Copy link
Collaborator Author

insearchoflosttime commented Jul 27, 2022

I think that's a great idea, I will update this accordingly

Signed-off-by: Joanne Koong <[email protected]>
Copy link
Collaborator

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@insearchoflosttime insearchoflosttime merged commit 445e535 into master Jul 28, 2022
@insearchoflosttime insearchoflosttime deleted the map_freeze branch July 28, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants